root
root copied to clipboard
Very long text string generated a wrong SVG file
Fix this issue.
The change inserts a new line in the SVG file before the <\text> tag. This avoids the syntax error the user sees when inserting a very long text.
Starting build on ROOT-performance-centos8-multicore
/soversion
, ROOT-ubuntu2204
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac12arm
/cxx20
, windows10
/default
How to customize builds
Test Results
10 files 10 suites 1d 15h 59m 50s :stopwatch: 2 498 tests 2 498 :white_check_mark: 0 :zzz: 0 :x: 23 879 runs 23 879 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 74633940.
The long line produces a syntax error. The </text>
was truncated.
Was the right commit pushed? It seems the change here is just a debug printout.
The change is not a debug printout, it inserts a new line in the SVG file before the <\text>
tag. This avoids the syntax error the user sees when inserting a very long text.
The change is not a debug printout, it inserts a new line in the SVG file before the <\text> tag. This avoids the syntax error the user sees when inserting a very long text.
Thanks for the explanation! Could you add this as a comment just before the change, and also link it to the github issue that triggered it for reference?
It is not necessary. This code is every where n that class. That's the way it works. It was just forgotten. If we comment that one we will need to comment everywhere....
Ok, can I at least ask to write it in the commit message :)?