root [PyROOT] Update CPyCppyy to `master`

Just to experiment with the CI for now.

This will close the following GitHub issue:

https://github.com/root-project/root/issues/12718
https://github.com/root-project/root/issues/7686
https://github.com/root-project/root/issues/11924
https://github.com/root-project/root/issues/12230

Jan 31 '24 17:01 guitargeek

Test Results

11 files 11 suites 2d 8h 31m 25s :stopwatch: 2 602 tests 2 601 :white_check_mark: 0 :zzz: 1 :x: 26 692 runs 26 691 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 9c4418af.

:recycle: This comment has been updated with latest results.

Jan 31 '24 23:01 github-actions[bot]

@guitargeek @vepadulano This also fixes the issue

https://github.com/root-project/root/issues/12230

Where the updated buffer interface utilizes the itemsize to determine incompatibility between implicitly declared double type numpy arrays and the cast to float in cppyy.gbl.std.vector

Feb 13 '24 09:02 aaronj0

Another issue fixed by moving to master https://github.com/root-project/root/issues/12230

Feb 13 '24 09:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

Mar 15 '24 16:03 phsft-bot

Hi @smuzaffar! This is a big upgrade, and testing it with CMSSW would give us more confidence, the ROOT tests are all green already. Can you give us a hand? Thanks!

Mar 15 '24 17:03 guitargeek

@guitargeek , cmssw tests via https://github.com/cms-sw/root/pull/205

Mar 15 '24 21:03 smuzaffar

Thank you!

Mar 15 '24 23:03 guitargeek

@smuzaffar , thanks also from me - appreciated!

Mar 16 '24 04:03 dpiparo

FYI , cmssw tests passed https://github.com/cms-sw/root/pull/205#issuecomment-2001831508

Mar 16 '24 09:03 smuzaffar

This is great news! I'll stop making code changes to the PR now, so we keep the validated state. I'll just need to update a few more times for the commit history and bookkeeping of patches.

Mar 16 '24 16:03 guitargeek

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

Mar 16 '24 16:03 phsft-bot

Build failed on windows10/default. See console output.

Mar 16 '24 16:03 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

Mar 18 '24 10:03 phsft-bot

I strongly believe we should have a similar approach as with our LLVM fork. We need to have some "source of truth" that is a certain cppyy/CPyCPPyy tag from upstream and then a clear way to reach the status of our fork from there, i.e. a series of patches that can be applied without conflicts. This PR goes in that direction but doesn't implement it fully as the sync script refers to a repository outside of our organisation. Ideally we would have separate repositories (one for cppyy and one for CPyCppyy) that we can refer to

Thanks for raising this point. The situation will be improved in the next weeks, I'll try to get as many patches merged to upstream as possible. Then, based on how many differences are left, we can decide if we want to go with one (or multiple) separate repositories, or we stay with the patch files.

Mar 19 '24 16:03 guitargeek