root icon indicating copy to clipboard operation
root copied to clipboard

[math] Contour method has some problems with Minuit2

Open guitargeek opened this issue 2 years ago • 1 comments

I the RooFit interactive Minuit tutorial, there is this line here:

   // The contour algorithm in Minuit2 does not work for this tutorial
   m.setMinimizerType("Minuit");

The implementation of CONTOUR in Minuit2 should be fixed such that this is not necessary. The problem has something to do with the contours hitting the parameter boundaries.

If one tries to get different contours inside the boundary by changing the contour() to for example:

   RooPlot *frame = m.contour(frac, sigma_g2, 1, 1.4, 1.7);

the plot looks still a bit screwed up with out-of-place lines:

rf601-crop

Also this problem should be fixed.

guitargeek avatar Sep 26 '23 21:09 guitargeek

A comment in #13918 suggests this is fixed: is this true?

dpiparo avatar May 01 '24 18:05 dpiparo

@guitargeek @lmoneta just checking: can this be closed?

dpiparo avatar Aug 22 '24 12:08 dpiparo

Closing as per discussion with @lmoneta

dpiparo avatar Aug 22 '24 12:08 dpiparo

Nice. I also checked if the reproducer works now, and it's working fine.

guitargeek avatar Aug 23 '24 10:08 guitargeek