root icon indicating copy to clipboard operation
root copied to clipboard

[tmva] Import torch before loading libTMVA in TMVA PyTorch tutorials tests

Open lmoneta opened this issue 2 years ago • 22 comments

This PR provides some improvements in pymva, especially in PyMethodBase

lmoneta avatar Sep 19 '23 17:09 lmoneta

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Sep 19 '23 17:09 phsft-bot

@phsft-bot build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default

lmoneta avatar Sep 19 '23 17:09 lmoneta

Starting build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default How to customize builds

phsft-bot avatar Sep 19 '23 17:09 phsft-bot

@phsft-bot build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On

lmoneta avatar Sep 19 '23 17:09 lmoneta

Starting build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On How to customize builds

phsft-bot avatar Sep 19 '23 17:09 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 19 '23 17:09 phsft-bot

Test Results

       10 files         10 suites   2d 2h 33m 40s :stopwatch:   2 494 tests   2 492 :heavy_check_mark: 0 :zzz:   2 :x: 23 868 runs  23 857 :heavy_check_mark: 0 :zzz: 11 :x:

For more details on these failures, see this check.

Results for commit 7d44eaf0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 19 '23 19:09 github-actions[bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Sep 20 '23 13:09 phsft-bot

@phsft-bot build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On

lmoneta avatar Sep 20 '23 13:09 lmoneta

Starting build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On How to customize builds

phsft-bot avatar Sep 20 '23 13:09 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 20 '23 13:09 phsft-bot

Failures on Ubuntu2004 are due to use std::regex before loading the PyTorch module. See PyTorch issue: https://github.com/pytorch/pytorch/issues/49460#issuecomment-911365091

regex comes from libROOTNtuple (days component) loaded by TMVA dependency on RDataframe. Unfortunately cannot disable DAOS when running with testing=On.

Try now building without RDataframe

lmoneta avatar Sep 25 '23 08:09 lmoneta

@phsft-bot build on ROOT-ubuntu2004-clang/default with flags -Ddataframe=Off -DCTEST_TEST_EXCLUDE_NONE=On

lmoneta avatar Sep 25 '23 08:09 lmoneta

Starting build on ROOT-ubuntu2004-clang/default with flags -Ddataframe=Off -DCTEST_TEST_EXCLUDE_NONE=On How to customize builds

phsft-bot avatar Sep 25 '23 08:09 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Sep 25 '23 14:09 phsft-bot

@phsft-bot build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On -Ddataframe=Off

lmoneta avatar Sep 25 '23 14:09 lmoneta

Starting build on ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004-clang/default with flags -DCTEST_TEST_EXCLUDE_NONE=On -Ddataframe=Off How to customize builds

phsft-bot avatar Sep 25 '23 14:09 phsft-bot

Build failed on ROOT-ubuntu2004-clang/default. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-09-28T09:23:53.179Z] 1805/2265 Test #944: tutorial-tmva-TMVA_SOFIE_RSofieReader .............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.34 sec

Failing tests:

And 335 more

phsft-bot avatar Sep 28 '23 09:09 phsft-bot

@lmoneta, is this PR still needed? Is it worth to rebase it on master, or should it be closed?

guitargeek avatar May 30 '25 06:05 guitargeek

Last time I checked, all the TMVA tutorials with PyTorch were working just fine so it seems this PR is not required anymore :+1:

guitargeek avatar Nov 08 '25 11:11 guitargeek