root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

Add signpost for modules

Open ktf opened this issue 2 years ago • 46 comments

This Pull request:

Adds signpost intervals on macOS for module loading operations. This allows profiling expensive loaded modules when running under instruments.

Checklist:

  • [x] tested changes locally
  • [x] updated the docs (if necessary)

ktf avatar Jun 30 '23 22:06 ktf

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:04:42.995Z] stderr: error: Failed to merge in the changes.
  • [2023-06-30T22:04:50.679Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:04:48.776Z] stderr: error: Failed to merge in the changes.
  • [2023-06-30T22:04:59.251Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:01.188Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on mac11/noimt. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:07.293Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:25.613Z] stderr: error: Failed to merge in the changes.
  • [2023-06-30T22:05:29.715Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:32.533Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:29.214Z] stderr: error: Failed to merge in the changes.
  • [2023-06-30T22:05:34.205Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on mac11/noimt. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:05:57.760Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:06:50.027Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2023-06-30T22:07:38.532Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

In case you like the idea, the result is the following:

image

I.e. you will have a time range associated to each module loading and you should be able to correlate them with the actual memory increase.

ktf avatar Jun 30 '23 22:06 ktf

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 30 '23 22:06 phsft-bot

Build failed on mac11/noimt. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-30T23:10:03.727Z] FAILED: core/metacling/src/CMakeFiles/MetaCling.dir/TClingCallbacks.cxx.o
  • [2023-06-30T23:10:05.100Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallbacks.cxx:487:34: error: copying variable of type 'std::atomic<int>' invokes deleted constructor
  • [2023-06-30T23:10:11.687Z] FAILED: core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o
  • [2023-06-30T23:10:12.619Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:1057:28: error: copying variable of type 'std::atomic<int>' invokes deleted constructor

phsft-bot avatar Jun 30 '23 23:06 phsft-bot

Test Results

         8 files           8 suites   1d 14h 49m 34s :stopwatch:   2 476 tests   2 475 :heavy_check_mark: 0 :zzz: 1 :x: 18 761 runs  18 760 :heavy_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit bcc901ff.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 01 '23 05:07 github-actions[bot]

It's not clear to me what the actually issue with Jenkins is. It looks like a fluke in one of the jenkins components. Could you restart the test?

ktf avatar Jul 04 '23 11:07 ktf

Could you also comment on wether this contribution makes sense or if you are not interested?

ktf avatar Jul 04 '23 11:07 ktf

@phsft-bot build just on mac11/noimt

Axel-Naumann avatar Aug 04 '23 15:08 Axel-Naumann

Starting build on mac11/noimt How to customize builds

phsft-bot avatar Aug 04 '23 15:08 phsft-bot

@ktf, this looks awesome. Can you move the duplicated code in some utility function?

vgvassilev avatar Aug 04 '23 16:08 vgvassilev

Sure, I will address both comments once back from holidays.

ktf avatar Aug 05 '23 06:08 ktf

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:21:00.880Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

Warnings:

  • [2023-08-08T08:20:50.566Z] stderr: warning: skipped previously applied commit b37c8de34f

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:21:01.150Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

Warnings:

  • [2023-08-08T08:20:51.089Z] stderr: warning: skipped previously applied commit b37c8de34f

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:20:53.440Z] stderr: error: Failed to merge in the changes.
  • [2023-08-08T08:21:02.498Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on mac12arm/cxx20. Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:21:02.645Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

Warnings:

  • [2023-08-08T08:20:52.939Z] stderr: warning: skipped previously applied commit b37c8de34f

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on mac11/noimt. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:21:12.967Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

phsft-bot avatar Aug 08 '23 08:08 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2023-08-08T08:23:42.409Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1144 (message):

Warnings:

  • [2023-08-08T08:22:28.305Z] stderr: warning: skipped previously applied commit b37c8de34f

phsft-bot avatar Aug 08 '23 08:08 phsft-bot