root icon indicating copy to clipboard operation
root copied to clipboard

[meta] TClass: prefer typeid=>TClass map values with less Double32_t:

Open Axel-Naumann opened this issue 2 years ago • 25 comments

Both Foo<double> and Foo<Double32_t> have the same typeid. Before this commit, TClass::GetClass(typeid(Foo)) would return whatever was registered last. This is not "stable"; it depends on which branch is accessed first, or which TClass::GetClass call happens first, or which library is loaded first.

Make this more reporducible by consistently preferring types will less Double32_t / Float16_t occurrences uin the typename.

While at this, only remove a TClass from the typeid=>TClass map if it really is the value for the typename.

Axel-Naumann avatar Mar 13 '23 14:03 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Mar 13 '23 14:03 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-03-13T15:04:01.054Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Build failed on mac12/noimt. Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-03-13T15:04:28.851Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-03-13T15:04:37.857Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Test Results

         9 files           9 suites   2d 2h 1m 53s :stopwatch:   2 473 tests   2 473 :heavy_check_mark: 0 :zzz: 0 :x: 21 149 runs  21 149 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e99a2aba.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 13 '23 15:03 github-actions[bot]

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-03-13T15:33:19.589Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Mar 13 '23 15:03 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Mar 20 '23 13:03 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Mar 20 '23 13:03 phsft-bot

Ubuntu 2004 just ran out of disk.

Axel-Naumann avatar Mar 20 '23 16:03 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 22 '23 15:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 23 '23 14:06 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Jun 23 '23 14:06 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Jun 23 '23 14:06 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-23T14:26:40.594Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Jun 23 '23 14:06 phsft-bot

Build failed on mac11/noimt. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-23T14:52:26.816Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Jun 23 '23 14:06 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 23 '23 15:06 phsft-bot

Build failed on mac12arm/cxx20. Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-23T15:32:42.754Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Jun 23 '23 15:06 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-23T17:19:49.593Z] FAILED: tree/treeplayer/test/treetreeplayertestUnit

phsft-bot avatar Jun 23 '23 17:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 26 '23 13:06 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 26 '23 13:06 phsft-bot

@phsft-bot build just on ROOT-ubuntu2004/python3

Axel-Naumann avatar Jun 28 '23 09:06 Axel-Naumann

Starting build on ROOT-ubuntu2004/python3 How to customize builds

phsft-bot avatar Jun 28 '23 09:06 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 28 '23 10:06 phsft-bot

Revamped in https://github.com/root-project/root/pull/15599

dpiparo avatar May 22 '24 09:05 dpiparo