[ntuple,daos] Create wrappers around backend-specific structures
This Pull request introduces wrappers to obfuscate backend-specific implementation details, distancing the storage layer functionality in RPageStorageDaos from the concrete backend in RDaos and libdaos.
Changes or fixes:
- Wraps the dictionary that groups page requests by their co-locality keys (a type previously aliased as
MultiObjectRWOperation_t) into a new wrapper classMultiObjectRWOperation. The class manages the insertion of new request akeys and associated IOVs into the dictionary and exposesbeginandenditerators for it. - Moves
RDaosKeyto the header file and aliases the concrete types ofDistributionKey_tandAttributeKey_t, used by other structures in the backend. - Introduce wrapper structure
RDaosIovto obfuscate the libdaos-specificd_iov_tstructure andd_iov_set()call from the storage layer for object stores. - Hide DAOS error code resolution function (
d_errstr) inGetDaosError(). - Directly use existing
RDaosObject::ObjClassIdwrapper structure around the default metadata class definition in the storage layer.
Checklist:
- [x] tested changes locally + DAOS
delphinode - [x] updated the docs (if necessary)
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2023-01-24T23:18:11.449Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
@glmiotto IIUC, this is to be reviewed as an enhancement over the DAOS backend (i.e., improving separation between RDaos and the RPage{Source,Sink}Daos). Comments coming soon.
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:43:48.674Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:43:43.421Z] stderr: error: Failed to merge in the changes.
- [2023-04-19T09:43:48.651Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:43:57.458Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:43:52.352Z] stderr: error: Failed to merge in the changes.
- [2023-04-19T09:44:06.112Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:44:34.095Z] stderr: error: Failed to merge in the changes.
- [2023-04-19T09:45:08.299Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:45:19.137Z] stderr: error: Failed to merge in the changes.
- [2023-04-19T09:45:26.596Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Build failed on mac12/noimt. Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build See console output.
Errors:
- [2023-04-19T09:45:54.213Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds
Test Results
5 files 5 suites 1d 0h 27m 30s :stopwatch: 2 425 tests 2 419 :heavy_check_mark: 0 :zzz: 6 :x: 11 966 runs 11 945 :heavy_check_mark: 0 :zzz: 21 :x:
For more details on these failures, see this check.
Results for commit 778276ef.