root icon indicating copy to clipboard operation
root copied to clipboard

[PyROOT][10454] Prevent memory hogging issue when checking for enums

Open etejedor opened this issue 3 years ago • 3 comments

As reported in issue #10454, calling ClassInfo_IsEnum() repeatedly increases the memory consumption of the program. This does not happen with TEnum::GetEnum(), which can be used instead.

etejedor avatar Sep 22 '22 11:09 etejedor

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 22 '22 11:09 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2022-09-22T11:37:35.473Z] LINK : fatal error LNK1104: cannot open file 'C:\build\workspace\root-pullrequests-build\build\bin\libCore.dll' [C:\build\workspace\root-pullrequests-build\build\core\Core.vcxproj]

phsft-bot avatar Sep 22 '22 11:09 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-09-22T11:49:39.522Z] 1561/2405 Test #1298: tutorial-vecops-vo001_AdoptOrOwnMemory-py .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.51 sec
  • [2022-09-22T11:49:45.807Z] 1656/2405 Test #1187: tutorial-rcanvas-df104-py .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 21.04 sec
  • [2022-09-22T11:49:49.048Z] 1691/2405 Test #1188: tutorial-rcanvas-df105-py .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 24.33 sec
  • [2022-09-22T11:54:31.525Z] 2389/2405 Test #1134: tutorial-dataframe-df103_NanoAODHiggsAnalysis-py ..................................................***Failed Error regular expression found in output. Regex=[: error:] 7.63 sec
  • [2022-09-22T11:54:39.626Z] 2390/2405 Test #1135: tutorial-dataframe-df104_HiggsToTwoPhotons-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 8.27 sec
  • [2022-09-22T11:54:49.578Z] 2391/2405 Test #1136: tutorial-dataframe-df105_WBosonAnalysis-py ........................................................***Failed Error regular expression found in output. Regex=[: error:] 9.47 sec
  • [2022-09-22T11:54:57.676Z] 2392/2405 Test #1137: tutorial-dataframe-df106_HiggsToFourLeptons-py ....................................................***Failed Error regular expression found in output. Regex=[: error:] 9.40 sec
  • [2022-09-22T11:55:09.861Z] 2393/2405 Test #1138: tutorial-dataframe-df107_SingleTopAnalysis-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 10.06 sec

Failing tests:

And 4 more

phsft-bot avatar Sep 22 '22 12:09 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 22 '22 12:09 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 22 '22 12:09 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 22 '22 12:09 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-09-22T12:20:19.881Z] 1325/2349 Test #1239: tutorial-vecops-vo001_AdoptOrOwnMemory-py .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.40 sec
  • [2022-09-22T12:33:11.749Z] 1862/2349 Test #1076: tutorial-dataframe-df103_NanoAODHiggsAnalysis-py ..................................................***Failed Error regular expression found in output. Regex=[: error:] 4.41 sec
  • [2022-09-22T12:33:17.020Z] 1863/2349 Test #1077: tutorial-dataframe-df104_HiggsToTwoPhotons-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 4.83 sec
  • [2022-09-22T12:33:25.136Z] 1864/2349 Test #1078: tutorial-dataframe-df105_WBosonAnalysis-py ........................................................***Failed Error regular expression found in output. Regex=[: error:] 7.64 sec
  • [2022-09-22T12:33:29.394Z] 1866/2349 Test #1079: tutorial-dataframe-df106_HiggsToFourLeptons-py ....................................................***Failed Error regular expression found in output. Regex=[: error:] 5.12 sec
  • [2022-09-22T12:33:35.951Z] 1868/2349 Test #1080: tutorial-dataframe-df107_SingleTopAnalysis-py .....................................................***Failed Error regular expression found in output. Regex=[: error:] 6.34 sec

Failing tests:

phsft-bot avatar Sep 22 '22 12:09 phsft-bot

Test Results

    10 files      10 suites   1d 21h 52m 58s :stopwatch:  2 635 tests  2 619 :white_check_mark: 0 :zzz: 16 :x: 24 868 runs  24 779 :white_check_mark: 0 :zzz: 89 :x:

For more details on these failures, see this check.

Results for commit d38ffc57.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 08 '24 03:04 github-actions[bot]

@vepadulano Can you check why this seemingly straightforward change is making some test fail?

pcanal avatar May 09 '24 19:05 pcanal