Use nullptr in cling

[linev]

Avoid warnings when -Wzero-as-null-pointer-constant is specified

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

[Axel-Naumann]

I'd really like to avoid having to deal with the conflicts between this and the llvm upgrade. Can we close this and have a new version once the llvm upgrade is in?

[linev]

I would like to keep it open - just to have possibility to test against current master. We can return to the PR once LLVM upgrade done.

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

[phsft-bot]

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

• [2022-09-13T07:39:33.179Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/DeclExtractor.cpp:223:31: warning: implicit conversion of nullptr constant to 'bool' [-Wnull-conversion]

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

[phsft-bot]

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

• projectroot.roottest.python.distrdf.common.roottest_python_distrdf_common_test_all

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

• [2022-12-09T09:06:36.380Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalExecutor.cpp.o
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:243:1: error: version control conflict marker in file
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:243:3: error: expected primary-expression before ‘<<’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:243:5: error: expected primary-expression before ‘<<’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:243:7: error: expected primary-expression before ‘<’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:243:9: error: ‘HEAD’ was not declared in this scope
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:301:56: error: qualified-id in declaration before ‘(’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:320:31: error: a function-definition is not allowed here before ‘{’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:327:36: error: qualified-id in declaration before ‘(’ token
• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:345:39: error: qualified-id in declaration before ‘(’ token

And 57 more

Warnings:

• [2022-12-09T09:06:36.381Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:476:1: warning: control reaches end of non-void function [-Wreturn-type]
• [2022-12-09T09:06:37.308Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:371:10: warning: unused variable ‘ErrorReporter’ [-Wunused-variable]

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

• [2022-12-09T09:07:43.132Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/IncrementalJIT.cpp.o
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:1: error: version control conflict marker in file
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:401:1: error: version control conflict marker in file
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:404:3: error: ‘AllocInfo’ was not declared in this scope
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:405:12: error: expected ‘;’ before ‘m_RWData’
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:428:1: error: expected primary-expression before ‘public’
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:431:41: error: a function-definition is not allowed here before ‘{’ token
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:435:64: error: a function-definition is not allowed here before ‘{’ token
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:450:58: error: a function-definition is not allowed here before ‘{’ token
• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:468:84: error: a function-definition is not allowed here before ‘{’ token

And 35 more

Warnings:

• [2022-12-09T09:07:43.424Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:371:10: warning: unused variable ‘ErrorReporter’ [-Wunused-variable]
• [2022-12-09T09:07:48.896Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:476:1: warning: control reaches end of non-void function [-Wreturn-type]

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:1: error: version control conflict marker in file
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:3: error: expected primary-expression before ‘<<’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:5: error: expected primary-expression before ‘<<’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:7: error: expected primary-expression before ‘<’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:399:9: error: ‘HEAD’ was not declared in this scope
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:401:1: error: version control conflict marker in file
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:401:3: error: expected primary-expression before ‘==’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:401:5: error: expected primary-expression before ‘==’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:401:7: error: expected primary-expression before ‘=’ token
• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:403:3: error: ‘AllocInfo’ was not declared in this scope

And 48 more

Warnings:

• [2022-12-09T09:14:53.687Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalJIT.cpp:371:10: warning: unused variable ‘ErrorReporter’ [-Wunused-variable]
• [2022-12-09T09:15:02.427Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:476:1: warning: control reaches end of non-void function [-Wreturn-type]

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

• [2023-01-26T08:47:25.373Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

[vgvassilev]

I would prefer merging #12116 before this change.