root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

[Cling] improve cmd history support

Open jiangyilism opened this issue 3 years ago • 9 comments

Changes or fixes:

  1. Environment variable CLING_HISTFILE to specify history file path.
  2. Environment variable CLING_HISTSIZE to specify history size. The original behavior is to not set the history size explicitly. That is equivalent to unlimited history size according to textinput::History::AppendToFile() (history file will never be pruned so it grows indefinitely). This is probably not most users expect. @Axel-Naumann, @vgvassilev do you think it makes sense to set default cling history size to something like 500 ? (That changes current behavior.)

Checklist:

  • [X] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes #

jiangyilism avatar Aug 30 '22 14:08 jiangyilism

Can one of the admins verify this patch?

phsft-bot avatar Aug 30 '22 14:08 phsft-bot

@phsft-bot build

jiangyilism avatar Aug 30 '22 14:08 jiangyilism

@phsft-bot build

guitargeek avatar Sep 01 '22 13:09 guitargeek

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 01 '22 13:09 phsft-bot

(the build can only be triggered like this by the maintainers)

guitargeek avatar Sep 01 '22 13:09 guitargeek

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 01 '22 19:09 phsft-bot

@guitargeek The build failed in a strange way. Did jenkins build branch [cling_cmd_history_config](https://github.com/jiangyilism/root/tree/cling_cmd_history_config) of this pull request? From https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/153465/testReport/projectroot.roottest.python.distrdf/spark/roottest_python_distrdf_spark_test_all/ and https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/153465/ , It built root master branch cdd1bdf3b46 . Which does not contain my branch/commits . And the failing test roottest_python_distrdf_spark_test_all . seems related to several distrdf changes in master branch recently.

jiangyilism avatar Sep 02 '22 08:09 jiangyilism

@guitargeek , @pcanal , @Axel-Naumann Could anyone help reviewing this patch?

jiangyilism avatar Sep 19 '22 13:09 jiangyilism

@jiangyilism, thanks for your patch! Looks reasonable approach to me. Can you add some tests for it?

vgvassilev avatar Sep 19 '22 18:09 vgvassilev

@vgvassilev Test is added. Please help resume github pipeline.

jiangyilism avatar Oct 05 '22 13:10 jiangyilism

@phsft-bot build!

vgvassilev avatar Oct 10 '22 13:10 vgvassilev

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Oct 10 '22 13:10 phsft-bot

Many thanks for the contribution, @jiangyilism! 🙂

In principle, LGTM, but I will defer the approval to @vgvassilev. Could you apply the included suggestions in the interim?

Sure. Thanks for the feedback.

jiangyilism avatar Jan 23 '23 21:01 jiangyilism

@phsft-bot build!

vgvassilev avatar Jan 25 '23 09:01 vgvassilev

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jan 25 '23 09:01 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-01-25T09:21:04.295Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

phsft-bot avatar Jan 25 '23 09:01 phsft-bot