root icon indicating copy to clipboard operation
root copied to clipboard

[RF] Improve weight handling in RooFit dataset classes

Open guitargeek opened this issue 3 years ago • 6 comments

This refactors a bit the data weight code, especially for the RooDataHist. The primary goal is that the data store classes don't have any implementation details anymore dedicated to the RooDataHist only, and don't duplicate any logic for RooDataHist weight and weight error evaluation. Further more, this PR also does some code modernization of RooDataHist and removes unneeded code.

With all these changes, it is much easier to understand for the reader of the code how the RooDataHist manages weights and how the RooAbsDataStore is used to that end.

More details in the commit descriptions.

guitargeek avatar Aug 29 '22 12:08 guitargeek

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Oct 13 '22 14:10 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Oct 13 '22 14:10 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-10-13T16:19:22.155Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/gui/browserv7/src/RBrowserTreeWidget.cxx:28:9: warning: private field 'fFirstSend' is not used [-Wunused-private-field]

phsft-bot avatar Oct 13 '22 17:10 phsft-bot