root icon indicating copy to clipboard operation
root copied to clipboard

[DF] Avoid RVec construction+swap when possible

Open eguiraud opened this issue 3 years ago • 7 comments
trafficstars

Rather than constructing a new RVec (as a view over the new array data) at every event and swapping with the old one, directly change the address of the old RVec.

This provides a ~10% performance improvement for a synthetic version of the dimuon tutorial adapted to only read (uncompressed) data.

eguiraud avatar Aug 22 '22 09:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 22 '22 09:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 22 '22 10:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 22 '22 11:08 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 22 '22 11:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 22 '22 11:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 22 '22 15:08 phsft-bot

The jenkins logs are gone, but the test failure is due to certain RDF warnings being printed out that were not printed before. I'll have to investigate why (and whether the correct behavior is warning or no warning).

eguiraud avatar Sep 13 '22 08:09 eguiraud

Will be superseded by bulk RDF making use of https://github.com/root-project/root/pull/12671 .

eguiraud avatar Apr 19 '23 14:04 eguiraud