root icon indicating copy to clipboard operation
root copied to clipboard
verified publisher icon root-project

[RF] Multiple RooAddPdf improvements that also speed up the evaluation in BatchMode

Open guitargeek opened this issue 3 years ago • 3 comments

This PR applies several improvements to the RooAddPdf class:

  1. Avoid code duplication of updateCoefficients() with RooAddModel
  2. Reduce footprint of cache object by using std::vector and avoid creating dummy RooRealVars
  3. Avoid redundant computation of raw coefficient values in BatchMode, which fixes performance problems in important fits like the ATLAS Higgs combination

More details can be found in the commit descriptions.

guitargeek avatar Aug 09 '22 16:08 guitargeek

@phsft-bot build

guitargeek avatar Aug 10 '22 19:08 guitargeek

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 10 '22 19:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 10 '22 20:08 phsft-bot