root icon indicating copy to clipboard operation
root copied to clipboard

[DF] Decouple type of RVariation storage from type returned by Vary expression

Open eguiraud opened this issue 3 years ago • 1 comments

To this end, we now propagate compile-time information on how many columns are varied (one or more than one simultaneously) down from Vary to RVariation.

We can take advantage of this information to simplify a number of helper functions, e.g. substituting SFINAE with simple function overloading, and to specify a storage type for results of Vary expressions potentially different from the type returned by the expression itself, which will be necessary to implement bulk evaluation of systematic variations.

eguiraud avatar Aug 08 '22 18:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 08 '22 18:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 01 '22 10:09 phsft-bot

rebased to fix issues with xrootd, but the only new commits are the last 3, which address some of the review comments

eguiraud avatar Sep 01 '22 10:09 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 01 '22 10:09 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 01 '22 11:09 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 01 '22 16:09 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 05 '22 11:09 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Sep 05 '22 15:09 phsft-bot