root icon indicating copy to clipboard operation
root copied to clipboard
verified publisher icon root-project

[VecOps] Do not enforce const-ness in Map function parameters

Open eguiraud opened this issue 3 years ago • 12 comments

Before this PR, the lambda passed to VecOps::Map could not take arguments by non-const reference as the implementation was adding a const qualifier to the RVec arguments.

We now instead forward RVecs from Map to MapImpl keeping their cv qualifiers.

A test has been added.

eguiraud avatar Aug 03 '22 22:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on windows10/cxx14. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on mac11/cxx14. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on mac1015/cxx17. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. See console output.

phsft-bot avatar Aug 03 '22 22:08 phsft-bot

@phsft-bot build

eguiraud avatar Aug 04 '22 15:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 04 '22 15:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-04T16:30:36.764Z] 781/2402 Test #478: tutorial-dataframe-df002_dataModel ................................................................***Failed Error regular expression found in output. Regex=[: error:] 2.92 sec
  • [2022-08-04T16:31:44.711Z] 1465/2402 Test #1112: tutorial-dataframe-df002_dataModel-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 15.86 sec

Failing tests:

phsft-bot avatar Aug 04 '22 16:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-04T16:36:35.812Z] 582/2344 Test #458: tutorial-dataframe-df002_dataModel ................................................................***Failed Error regular expression found in output. Regex=[: error:] 4.55 sec
  • [2022-08-04T16:41:33.792Z] 1161/2344 Test #1052: tutorial-dataframe-df002_dataModel-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 18.14 sec

Failing tests:

phsft-bot avatar Aug 04 '22 17:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 04 '22 18:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 11 '22 08:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 11 '22 09:08 phsft-bot