root icon indicating copy to clipboard operation
root copied to clipboard
verified publisher icon root-project

[tree] Integrate rootreadspeed into ROOT

Open dkpoult opened this issue 3 years ago • 45 comments

This Pull request:

Adds the rootreadspeed executable to the ROOT package.

It allows for testing throughputs when reading .root files under various configurations.

Changes or fixes:

  • Integrates the source code into ROOT (under tree/readspeed)
  • Adds the rootreadspeed executable, runnable once ROOT has been installed
  • Adds a new test suite for the readspeed application

Checklist:

  • [x] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes - N/A

dkpoult avatar Aug 03 '22 13:08 dkpoult

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:22:23.406Z] [ 7%] CopyingCMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:24:08.333Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-03T13:24:08.333Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:23:56.472Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /mnt/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-03T13:23:56.472Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:27:24.526Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Users/sftnight/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-03T13:27:24.526Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:33:42.355Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Volumes/HD2/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-03T13:33:42.355Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-03T13:43:44.189Z] CMake Error at tree/readspeed/CMakeLists.txt:17 (add_dependencies):
  • [2022-08-03T13:43:50.267Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1160 (message):

phsft-bot avatar Aug 03 '22 13:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(138,15): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(138,15): error C2146: syntax error: missing ';' before identifier 'effectiveThreads' [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(138,15): error C2065: 'effectiveThreads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(141,86): error C2065: 'effectiveThreads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(142,40): error C2065: 'effectiveThreads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(144,84): error C2065: 'effectiveThreads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]
  • [2022-08-03T14:04:05.643Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\src\ReadSpeedCLI.cxx(145,40): error C2065: 'effectiveThreads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\ReadSpeed.vcxproj]

phsft-bot avatar Aug 03 '22 14:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 04 '22 11:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2022-08-04T12:07:26.697Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(255,15): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.697Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(255,15): error C2146: syntax error: missing ';' before identifier 'threads' [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.697Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(255,15): error C2065: 'threads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(260,4): error C2065: 'threads': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(260,4): error C2737: 'gtest_ar': const object must be initialized [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(265,15): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(265,15): error C2146: syntax error: missing ';' before identifier 'oldTasksPerWorker' [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(265,15): error C2065: 'oldTasksPerWorker': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:26.970Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(275,22): error C2065: 'oldTasksPerWorker': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]
  • [2022-08-04T12:07:27.268Z] C:\build\workspace\root-pullrequests-build\root\tree\readspeed\test\readspeed_general.cxx(282,4): error C2065: 'oldTasksPerWorker': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\readspeed\test\readspeed_general.vcxproj]

And 2 more

phsft-bot avatar Aug 04 '22 12:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 04 '22 12:08 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-04T12:55:32.500Z] CMake Error at tree/readspeed/CMakeLists.txt:17 (add_dependencies):
  • [2022-08-04T12:55:38.573Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1160 (message):

phsft-bot avatar Aug 04 '22 12:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 05 '22 10:08 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-05T10:09:12.038Z] collect2: error: ld returned 1 exit status

phsft-bot avatar Aug 05 '22 10:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 05 '22 10:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 08 '22 09:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 08 '22 12:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 08 '22 13:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 08 '22 17:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 10 '22 09:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T09:59:25.949Z] [ 5%] Copying header /data/sftnight/workspace/root-pullrequests-build/root/hist/hist/inc/TF1Convolution.h to /data/sCMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T10:00:12.599Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /mnt/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-10T10:00:12.599Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T10:00:50.270Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T10:00:48.958Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-10T10:00:48.958Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T10:05:18.154Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Users/sftnight/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-10T10:05:18.154Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-10T10:25:00.914Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Volumes/HD2/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-08-10T10:25:00.914Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

phsft-bot avatar Aug 10 '22 10:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 10 '22 11:08 phsft-bot

Hey @dkpoult can you please rebase this branch and fix conflicts? :grimacing:

eguiraud avatar Aug 11 '22 18:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 12 '22 08:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 12 '22 09:08 phsft-bot