root
root copied to clipboard
root-project
[GSOC][TMVA][SOFIE] Shape ONNX Operator implemented with the corresponding unit tests
This Pull request: Adds the Shape ONNX Operator with the corresponding unit tests
Checklist:
- [ ] tested changes locally
- [ ] updated the docs (if necessary)
This PR fixes #
@phsft-bot build just on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On
Build failed on ROOT-ubuntu2004/default. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-08-19T09:57:21.760Z] FAILED: lib/modules.idx
- [2022-08-19T09:57:21.760Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util
@phsft-bot build just on ROOT-ubuntu2204/default with flags -Dtmva-sofie=On
Build failed on ROOT-ubuntu2204/default. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-08-19T10:06:47.977Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-08-19T10:06:49.641Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-08-19T10:06:53.210Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-08-19T10:06:56.633Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
I have made some changes related to Shape Operator. Here is the error i am facing for converting fShape to string and also in the output its not accepting std::vector<int>
@Neel-Shah-29 : see my comments above for fixing the errors you are having.
@phsft-bot build just on ROOT-ubuntu2204/default with flags -Dtmva-sofie=On
Build failed on ROOT-ubuntu2204/default. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-08-23T16:36:24.018Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1539:20: warning: ‘this’ pointer is null [-Wnonnull]
- [2022-08-23T16:48:34.783Z] /home/sftnight/build/workspace/root-pullrequests-build/build/tmva/sofie/test/Shape_FromONNX.hxx:20:35: warning: unused parameter ‘tensor_X’ [-Wunused-parameter]
Failing tests:
- projectroot.roottest.root.collection.roottest_root_collection_runDeleteWarning
- projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_simpleWriteRead
- projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_simpleRead
- projectroot.roottest.root.io.uniquePointer.roottest_root_io_uniquePointer_aclicDataMemberSelection
- projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_runaliceesd
- projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make
The PR looks good. There is only one thing missing. The Shape operator is not using the optional attributes
endandstartwhich define the ending and initial position of the tensor from which one wants to have the shape. See the ONNX documentation: https://github.com/onnx/onnx/blob/main/docs/Operators.md#Shape. I think would be nice to add this functionality to be compliant with the ONNX standard
Sir i have implemented the Start and End Optional attributes but currently its giving a segmentation fault on build.
@Neel-Shah-29 , can you please fix the code as suggested in the comment above and fix also the conflicts so we can test in the CI Thank you !
Now the conflicts are fixed and comment is applied we can run the CI tests.
@phsft-bot build just on ROOT-ubuntu2204/default with flags -Dtmva-sofie=On
Build failed on ROOT-ubuntu2204/default. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-09-02T13:08:08.962Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-02T13:08:12.947Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-02T13:08:23.364Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-02T13:08:24.949Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
@phsft-bot build just on ROOT-ubuntu2204/default with flags -Dtmva-sofie=On
Build failed on ROOT-ubuntu2204/default. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-09-06T08:00:47.203Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-06T08:00:48.672Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-06T08:00:59.632Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
- [2022-09-06T08:01:01.033Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]