root
root copied to clipboard
root-project
Drop llvm::GlobalValue in DeferredDeclsToEmit
The previous cling patches wraps DeferredDeclsToEmit(vector<GlobalDecl>)
into a struct that contains a llvm::GlobalVlaue, but it seems that this
field is useless and can be dropped. I have tested this patch in Cling and
spotted no new tests failing, so let's give ROOT a try.
Signed-off-by: Jun Zhang [email protected]
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.python.distrdf.dask.roottest_python_distrdf_dask_test_all
- projectroot.roottest.python.distrdf.spark.roottest_python_distrdf_spark_test_all
@Axel-Naumann, do you remember the use case or the test we had where this fix helps? Our current understanding is that it is not needed anymore.
yes, tests results https://github.com/cms-sw/root/pull/174#issuecomment-1221750811 look good
LGTM, @junaire which was that patch in our spreadsheet again?
It occurs in several ones, I collected them and merge them all into this one.
LGTM, @junaire which was that patch in our spreadsheet again?
It occurs in several ones, I collected them and merge them all into this one.
Can you add comments so we can mark these patches in green in the doc?
LGTM, @junaire which was that patch in our spreadsheet again?
It occurs in several ones, I collected them and merge them all into this one.
Can you add comments so we can mark these patches in green in the doc?
Sure, I'll figure it out and add some notes, it's been a while...