root icon indicating copy to clipboard operation
root copied to clipboard
verified publisher icon root-project

[physics] Add conversion to ROOT::Math::XYZTVector

Open Axel-Naumann opened this issue 3 years ago • 11 comments

As a wonderful side-effect, this adds support for construction from a TLorentzVector.

See https://root-forum.cern.ch/t/problem-initializing-a-4-vector/50789

Axel-Naumann avatar Jul 26 '22 14:07 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 26 '22 14:07 phsft-bot

That overload doesn't work, back to drawing board.

Axel-Naumann avatar Jul 26 '22 14:07 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 26 '22 15:07 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jul 26 '22 15:07 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 20 '22 12:09 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-09-20T12:50:18.386Z] FAILED: tmva/sofie/G__ROOTTMVASofie.cxx lib/ROOTTMVASofie.pcm /Users/sftnight/build/workspace/root-pullrequests-build/build/tmva/sofie/G__ROOTTMVASofie.cxx /Users/sftnight/build/workspace/root-pullrequests-build/build/lib/ROOTTMVASofie.pcm
  • [2022-09-20T12:50:20.302Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/TMVA/SOFIE_common.hxx:116:25: error: missing '#include "/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/sstream"'; definition of 'basic_stringstream' must be imported from module 'std.sstream' before it is required

phsft-bot avatar Sep 20 '22 12:09 phsft-bot

Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-09-20T13:20:17.970Z] FAILED: tmva/sofie/G__ROOTTMVASofie.cxx lib/ROOTTMVASofie.pcm /Volumes/HD2/build/workspace/root-pullrequests-build/build/tmva/sofie/G__ROOTTMVASofie.cxx /Volumes/HD2/build/workspace/root-pullrequests-build/build/lib/ROOTTMVASofie.pcm
  • [2022-09-20T13:20:19.880Z] /Volumes/HD2/build/workspace/root-pullrequests-build/build/include/TMVA/SOFIE_common.hxx:116:25: error: missing '#include "/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/sstream"'; definition of 'basic_stringstream' must be imported from module 'std.sstream' before it is required

phsft-bot avatar Sep 20 '22 13:09 phsft-bot

@phsft-bot build

Axel-Naumann avatar Sep 21 '22 08:09 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Sep 21 '22 08:09 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-09-21T08:44:36.847Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T08:44:36.847Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T08:44:36.847Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T08:44:36.847Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]

phsft-bot avatar Sep 21 '22 09:09 phsft-bot

Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-09-21T12:36:22.978Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T12:36:22.978Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'N' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T12:36:22.978Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  • [2022-09-21T12:36:22.978Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Softmax.hxx:97:21: warning: variable 'iStride' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]

phsft-bot avatar Sep 21 '22 13:09 phsft-bot

@phsft-bot build

Axel-Naumann avatar Nov 14 '22 11:11 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Nov 14 '22 11:11 phsft-bot