root icon indicating copy to clipboard operation
root copied to clipboard

Resolve the alerts produced by "LGTM analysis: Python"

Open ikabadzhov opened this issue 3 years ago • 0 comments

LGTM analysis: Python is "picking" code inside of ROOT, which has unnecessary imports. We saw that only writing import ROOT led to 4 alerts from the LGTM tool. Example:

This pull request introduces 4 alerts and fixes 10 when merging 30c5db08c504abc8f4c3f7b822defecf5157dcc4 into 56c28ff3b846c74f8c36c53320d381545f6b31f9 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 10 for Module-level cyclic import

(https://github.com/root-project/root/pull/11038#issuecomment-1194049285)

fyi: @j-mathe

ikabadzhov avatar Jul 25 '22 20:07 ikabadzhov