root
root copied to clipboard
Simplify CallFunc
This patch reduces the code bloat in TClingCallFunc trying to make the code more readable.
cc: @sudo-panda
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.runtutorials.tutorial_legacy_thread_threadsh1
- projectroot.runtutorials.tutorial_io_testMergeCont
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on ROOT-debian10-i386/soversion. Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_assertUnload_auto
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-debian10-i386/soversion. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_assertUnload_auto
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.
Failing tests:
@vgvassilev can you make that a PR / ready to review when it's passing the tests, please? And for our CI infra's occupancy and energy consumption / global warming it actually helps if you could just run roottest on your machine before submitting a PR, at least for non-trivial changes.
Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.treeformula.clones.roottest_root_treeformula_clones_make
- projectroot.roottest.root.io.customCollection.roottest_root_io_customCollection_make
- projectroot.roottest.root.meta.callfunc.roottest_root_meta_callfunc_runsimpleFunc_auto
- projectroot.roottest.root.treeformula.references.roottest_root_treeformula_references_make
- projectroot.roottest.root.meta.roottest_root_meta_drawing
- projectroot.roottest.root.treeformula.function.roottest_root_treeformula_function_make
- projectroot.roottest.root.treeformula.retobj.roottest_root_treeformula_retobj_make
- projectroot.roottest.root.meta.roottest_root_meta_runInterpreterValue_auto
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-07-02T19:10:06.464Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/Value.cpp.o
- [2022-07-02T19:10:06.721Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope
- [2022-07-02T19:10:06.721Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-07-02T19:10:07.877Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/Value.cpp.o
- [2022-07-02T19:10:07.877Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope; did you mean ‘ET’?
- [2022-07-02T19:10:07.877Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Errors:
- [2022-07-02T19:13:07.507Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope
- [2022-07-02T19:13:07.507Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-07-02T19:22:26.077Z] /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]
Failing tests:
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-07-02T19:23:01.746Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]
Failing tests:
Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-07-02T19:26:00.754Z] /data/sftnight/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]
Failing tests:
- projectroot.runtutorials.tutorial_rcanvas_rcanvas_update.cxx
- projectroot.runtutorials.tutorial_rcanvas_raxis.cxx
- projectroot.runtutorials.tutorial_rcanvas_rbox.cxx
- projectroot.runtutorials.tutorial_rcanvas_rframe.cxx
- projectroot.runtutorials.tutorial_rcanvas_rh1_twoscales.cxx
- projectroot.runtutorials.tutorial_rcanvas_rh1.cxx
- projectroot.runtutorials.tutorial_rcanvas_rh1_large.cxx
- projectroot.runtutorials.tutorial_rcanvas_rmarker.cxx
- projectroot.runtutorials.tutorial_rcanvas_rline.cxx
- projectroot.runtutorials.tutorial_rcanvas_rline_width.cxx
And 20 more
Starting build on ROOT-debian10-i386
/soversion
, ROOT-performance-centos8-multicore
/cxx17
, ROOT-ubuntu18.04
/nortcxxmod
, ROOT-ubuntu2004
/python3
, mac1015
/cxx17
, mac11
/cxx14
, windows10
/cxx14
How to customize builds
Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.
Warnings:
- [2022-07-02T21:14:43.949Z] /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]