root icon indicating copy to clipboard operation
root copied to clipboard

Simplify CallFunc

Open vgvassilev opened this issue 2 years ago • 87 comments

This patch reduces the code bloat in TClingCallFunc trying to make the code more readable.

cc: @sudo-panda

vgvassilev avatar Jun 28 '22 20:06 vgvassilev

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 28 '22 20:06 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 28 '22 21:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 29 '22 06:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 29 '22 08:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 29 '22 09:06 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 29 '22 11:06 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 29 '22 12:06 phsft-bot

@vgvassilev can you make that a PR / ready to review when it's passing the tests, please? And for our CI infra's occupancy and energy consumption / global warming it actually helps if you could just run roottest on your machine before submitting a PR, at least for non-trivial changes.

Axel-Naumann avatar Jun 29 '22 16:06 Axel-Naumann

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-07-02T19:10:06.464Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/Value.cpp.o
  • [2022-07-02T19:10:06.721Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope
  • [2022-07-02T19:10:06.721Z] /mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-07-02T19:10:07.877Z] FAILED: interpreter/cling/lib/Interpreter/CMakeFiles/obj.clingInterpreter.dir/Value.cpp.o
  • [2022-07-02T19:10:07.877Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope; did you mean ‘ET’?
  • [2022-07-02T19:10:07.877Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-07-02T19:13:07.507Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:264:58: error: ‘QT’ was not declared in this scope
  • [2022-07-02T19:13:07.507Z] /data/sftnight/workspace/root-pullrequests-build/root/interpreter/cling/lib/Interpreter/Value.cpp:267:5: error: ‘QT’ was not declared in this scope

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-07-02T19:22:26.077Z] /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-07-02T19:23:01.746Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-07-02T19:26:00.754Z] /data/sftnight/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]

Failing tests:

And 20 more

phsft-bot avatar Jul 02 '22 19:07 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 02 '22 21:07 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-07-02T21:14:43.949Z] /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TClingCallFunc.cxx:1411:19: warning: unused variable ‘num_params’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Jul 02 '22 21:07 phsft-bot