root icon indicating copy to clipboard operation
root copied to clipboard

Difficult to configure Xrootd to use non-builtin openssl

Open Axel-Naumann opened this issue 3 years ago • 3 comments

Explain what you would like to see improved

In builtins/xrootd/CMakeLists.txt we don't pass any openssl configuration over to Xrootd. This causes inconsistent builds for ROOT and xrootd.

Optional: share how it could be improved

Maybe use

OPENSSL_CRYPTO_LIBRARY
OPENSSL_SSL_LIBRARY
OPENSSL_INCLUDE_DIR

as made available with Xrootd's CMakeLists.txt.

To Reproduce

See https://root-forum.cern.ch/t/building-from-source-root-v6-26-00-failing-with-openssl-on-macos-monterey/49078

Axel-Naumann avatar Mar 08 '22 16:03 Axel-Naumann

@Axel-Naumann According to the Xrootd README, the only OpenSSL related variable we can pass is OPENSSL_ROOT_DIR. Not sure it would solve this issue...

bellenot avatar Mar 31 '22 14:03 bellenot

@amadio what's your take on this?

dpiparo avatar May 17 '24 07:05 dpiparo

XRootD now uses the standard CMake module to link against OpenSSL. If you configure ROOT correctly, you should be able to just forward the OpenSSL variables to XRootD and it should work. If not, please let me know.

amadio avatar May 17 '24 15:05 amadio

Only one line of change needed to close an issue? Let's go:

  • https://github.com/root-project/root/pull/15697

guitargeek avatar May 31 '24 14:05 guitargeek