plik icon indicating copy to clipboard operation
plik copied to clipboard

Onetime downloads under unstable internet connections?

Open andneuma opened this issue 5 years ago • 3 comments

Hey there, another question: We've encountered that plik removes a Onetime-Download once the download started. In case of a broken connection the download is not available any more for a re-transfer. Is that expected behaviour?

best, Andi

andneuma avatar Jan 15 '20 12:01 andneuma

Hello,

This is indeed the expected behavior once you've started to download a one-shot upload file it's over whatever if you succeed to read everything or not. However I totally get your point.

I'm not sure that we should change this behavior as it would mean that one could read the file until the byte before the last byte without changing the status of the file.

camathieu avatar Jan 26 '20 20:01 camathieu

Hello camathieu, thank you for your reply, I can as well see your point! As far as I understand your concern is, that one could download a one-shot upload multiple times. We think that probably the common scenario would be a connection break. Would it be plausible to configure different behaviors of the the backend here?

andneuma avatar Jan 27 '20 10:01 andneuma

For 1.3 we will have guarantees to have only one download at the same time for on shot files. We'll just rollback the file status If the copy didn't successfully go through.

On Mon, 27 Jan 2020, 11:31 Andreas Neumann, [email protected] wrote:

Hello camathieu, thank you for your reply, I can as well see your point! As far as I understand your concern is, that one could download a one-shot upload multiple times. We think that probably the common scenario would be a connection break. Would it be plausible to configure different behaviors of the the backend here?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/root-gg/plik/issues/281?email_source=notifications&email_token=ABQ5XPVMLVJWRAPZXCN6RP3Q72ZZBA5CNFSM4KHC4DQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7AXFA#issuecomment-578685844, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ5XPWPLNXOOFKWFVCNFVTQ72ZZBANCNFSM4KHC4DQA .

camathieu avatar Jan 29 '20 08:01 camathieu