ad-qolsys icon indicating copy to clipboard operation
ad-qolsys copied to clipboard

Fix MQTT Discovery by defining a default/catch-all binary_sensor device_class

Open jsb5151 opened this issue 3 years ago • 4 comments

  1. catch-all for unspecified device class mappings
  2. remove unnecessary version_key and source_key payloads from arming command

jsb5151 avatar Oct 31 '21 21:10 jsb5151

@jsb5151 Can you look at the questions I asked?

roopesh avatar Dec 07 '21 13:12 roopesh

I manually applied the changed on this PR to my install, but I still have devices showing not getting classed right - Specifically Key Fob, Spare Key Fob, Garage, Garage Bay, and Panel Glass Break..

BShurilla avatar Feb 01 '22 21:02 BShurilla

@jsb5151 Can you look at the questions I asked?

I'm not sure what you're referring to...?

jsb5151 avatar Feb 02 '22 03:02 jsb5151

  1. Why are you removing the source_key and version_key?

  2. I am still curious why safety would be the catch-all

roopesh avatar Feb 02 '22 04:02 roopesh