rook icon indicating copy to clipboard operation
rook copied to clipboard

docs: rename Rook-Ceph to Rook Ceph

Open galexrt opened this issue 3 years ago • 7 comments

Description of your changes:

Signed-off-by: Alexander Trost [email protected]

Rename Rook-Ceph to Rook Ceph and add some more inline code "blocks" for highlighting flags in the Ceph Cluster CRD external script docs.

Checklist:

  • [x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • [x] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • [x] Reviewed the developer guide on Submitting a Pull Request
  • [x] Pending release notes updated with breaking and/or notable changes for the next minor release.
  • [x] Documentation has been updated, if necessary.
  • [x] Unit tests have been added, if necessary.
  • [x] Integration tests have been added, if necessary.

galexrt avatar Jun 16 '22 08:06 galexrt

@parth-gr Please post the link you viewed the docs on

galexrt avatar Jun 16 '22 09:06 galexrt

@parth-gr Please post the link you viewed the docs on

sure i saw the latest, https://rook.io/docs/rook/latest/CRDs/ceph-cluster-crd/#commands-on-the-k8s-consumer-cluster

parth-gr avatar Jun 16 '22 09:06 parth-gr

@parth-gr The numbered list continuation does not seem be fixable for mkdocs/python-markdown. I have changed the wording there to not need to rely on a numbered list. What do you think?

galexrt avatar Jun 16 '22 10:06 galexrt

@parth-gr The numbered list continuation does not seem be fixable for mkdocs/python-markdown. I have changed the wording there to not need to rely on a numbered list. What do you think?

Looks good

parth-gr avatar Jun 16 '22 10:06 parth-gr

This pull request has merge conflicts that must be resolved before it can be merged. @galexrt please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

mergify[bot] avatar Jun 28 '22 13:06 mergify[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 28 '22 20:07 github-actions[bot]

@travisn as discussed on Slack, I have split up the CI configuration page into a separate commit. PTAL

galexrt avatar Aug 11 '22 13:08 galexrt