Ronan Jouchet

Results 152 comments of Ronan Jouchet

Closing this as electron [*"don't have any plan to support Chrome extension APIs"*](https://github.com/electron/electron/issues/1498#issuecomment-96995155). Workarounds don't seem very satisfactory :-/ , but as @eladnava mentioned, system-wide blocking via hosts file (e.g....

> I just stumbled upon this issue and thought I would mention this JavaScript [adblocker library](https://github.com/cliqz-oss/adblocker) which I am maintaining. It has first-class support for electron and can be integrated...

Hi @sampotts, thanks for the detailed report . Can you try passing other Electron versions using our `-e` / `--electron-version` flag? Try `-e 13.5.2` and `-e 14.1.1` (and maybe other...

@sampotts thx. It miiight have to do with your machine, because there isn't much I could see causing this bug in [the v45.0.0 ... v45.0.4 range](https://github.com/nativefier/nativefier/compare/v45.0.0...v45.0.4?expand=1). The only potential culprit...

> I've had this issue ever since 45.0.1. I have tried different electron versions and none of them work. The root cause is some change in 45.0.0->45.0.1. If I downgrade...

@sampotts okay. One last bisection test: can you please try `v45.0.1` and `-e 13.1.7` ?

@sampotts @ashendon thanks for all the testing :hugs: . So, given that 45.0.1 crashes with recent Electrons but works with Electron 13.1.7, it's clear the problem doesn't come from code...

@alxlg @darrenhaken @eduardo-robles @ghost @leonidas @mlncn @mvoropaiev @quanglam2807 @tdgroot : I'm looking at @leonidasv 's PR adding automatic creation of `.desktop` files: https://github.com/jiahaog/nativefier/pull/729 . - I'm okay with that, because...

So, #799 (a duplicate of this issue) reminded me this issue is still open, and I didn't merge PR #729 (sorry @leonidasv), for a reason I never took the time...

> I think the approach works, or alternatively this text could just be output in the Terminal instead of a separate README file. @cassidyjames my intention behind suggesting writing an...