create-expo-stack
create-expo-stack copied to clipboard
Added vexo analytics as an option for the analytics providers.
Feature Request
We'd like to add vexo as an option when creating an app in any of the possible configurations.
To do so:
- I've modified the corresponding files to support any analytics tool
- Added vexo as an option in the CLI
- Modified base index.ts file for Expo, so that we can use
ejs
in it to generate corresponding files - Included the code in
package.json
and added the code for React Navigation
Notes
I took the liberty of indenting correctly part of the code generated since at first glance, I thought it could be improved and a bit messy. In addition, we should solve the issue when we are generating ejs files, if
statements that are not met will leave a blank line.
Other than that, thank you very much! Eager to hear your thoughts
@falcoagustin Is there any configuration you'd like to add to projects beyond getting set up with an API key and a vexo account? As an FYI, we're about to have a documentation section on the website or we can simply link to your documentation.
Additionally, this PR will need to be rebased with main
given the new monorepo structure, @ernestoresende would you mind helping out with this?
For sure, but I'll have to be added as a direct collaborator to the repo and this PR should have Allow edits from maintainers turned on in order for me to contribute directly with commits from my end.
Alternatively, I can guide you and/or @falcoagustin on how to resolve the merge conflicts on your end.
For sure, but I'll have to be added as a direct collaborator to the repo and this PR should have Allow edits from maintainers turned on in order for me to contribute directly with commits from my end.
Alternatively, I can guide you and/or @falcoagustin on how to resolve the merge conflicts on your end.
Invited
@ernestoresende @danstepanov No further config I'd like on the tool. Initially it's a good starting point, we can then build in top of this if needed, as I'd like to keep things as simple as possible, not only for Vexo, but for other providers that are integrating with us. Everything should be as smooth as possible.
All good for me, I'll leave final review and merge to @danstepanov.
Thanks for your contribution and your patience with our monorepo shenanigans @falcoagustin 🚀
Sure thing! Thank you very much let me know if I can do anything else to help out
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
create-expo-stack-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 7, 2024 7:22am |
create-expo-stack-landing-page | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 7, 2024 7:22am |
@danstepanov
Being fair to @falcoagustin, some of the removed things that shouldn't have been removed might be a result of my rebase and subpar Git skills. That's on me.
From what I can see of his original commits, the only thing changed was indentation, ex.:
https://github.com/danstepanov/create-expo-stack/blob/61eaf1240b1fc102286159e585e597d4edef2181/src/templates/base/package.json.ejs#L23-L28
Not exactly sure what I might have done during the merge that caused this to happen, but I'll try restoring it to the original state if @falcoagustin is busy to take a look at this today.
That is correct @ernestoresende , none of my changes did change versions but only indentation since for the end project the indentation there was incorrect and untidy. That's also explained under notes section @danstepanov Will fix soon! Thanks for reviewing
If @ernestoresende you wanna take it today, feel free to! I'll take a peek over the weekend if that's okay
Think I have a better / more up to date rebase!
🦋 Changeset detected
Latest commit: b5614d5b7d78c0142a510686e709e4389258a4c4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
create-expo-stack | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@alejorod is attempting to deploy a commit to the ronin-tech Team on Vercel.
A member of the Team first needs to authorize it.
Update the PR to reflect the latest changes from main and added extra steps on success to guide the users with the vexo integration. Also added the vexo-analytics
to --help
and .env
vexo props.
Let us know if anything else is needed
@alejorod will review/test this in the morning, thanks!
@alejorod I provided feedback, can you also remove the changes that are just deleting empty lines? Not sure why our linter isn't catching those.
hey @danstepanov thanks for the feedback. I update the PR with those changes and left some comments regarding the prompt and .env
files
@falcoagustin once this is rebased with main
, we can merge!
@danstepanov rebase done! Let me know if anyhting else is missing
@alejorod Thanks for updating the PR! Couple nits:
- Please remove any changes which solely affect the format of the code
- Awaiting confirmation from @sammoore and @dannyhw re any additional changes needed due to work over the last week
Otherwise, everything LGTM
@danstepanov reverted changes which solely affect the format of the code