HeavenMS icon indicating copy to clipboard operation
HeavenMS copied to clipboard

The OdinMS inventory issue.

Open UltimateMors opened this issue 8 years ago • 3 comments

I'm connecting this to issue #122. Because I know this has been a problem since 2007. Where the creators of OdinMS thought it would be an good idea to delete all of the items in the inventory in order to reload them or some sort.

I know multiple servers have not fixed this, even the top servers that are around today. Is there a possible way to fix this? It's a very serious problem, because if a person disconnects while items are getting re-loaded, the whole inventory can be deleted.

UltimateMors avatar Nov 08 '17 19:11 UltimateMors

I'm acknowledged of this issue. As matter of fact, to have a private server properly deployed for production (to host a server that is), this one recorrent problem would have to be managed beforehand. Anyone inclined to help on this task is most welcome, by sending a PR here.

ronancpl avatar Nov 08 '17 21:11 ronancpl

To solve this, what needs to be done is a refactor on the load and save data queries, to prevent deleting then reinserting redundant rows on the tables and, instead, make it update these redundant rows, deleting or adding only those that are really necessary.

ronancpl avatar Nov 08 '17 22:11 ronancpl

I've solved this in my source, feel free to rip it https://github.com/tylerhasman/MapleStory/blob/50e7a450cf630b8693e3480242cf08b47d263080/src/maplestory/player/MapleCharacter.java#L1506

tylerhasman avatar May 04 '18 05:05 tylerhasman