gym-locm icon indicating copy to clipboard operation
gym-locm copied to clipboard

Merge bugfixes into main repo

Open ronaldosvieira opened this issue 1 year ago • 1 comments

ronaldosvieira avatar Jul 24 '23 19:07 ronaldosvieira

Hm, let me double check why I put that there. ------- Original Message ------- On Monday, July 24th, 2023 at 3:44 PM, Ronaldo Vieira @.***> wrote:

@ronaldosvieira commented on this pull request.


In gym_locm/engine.py:

@@ -670,6 +717,11 @@ def _act_on_draft(self, action: Action):

 def _act_on_battle(self, action: Action):
     """Execute the actions intended by the player in this battle turn"""
  •    # Reset drawn cards for both players
    
  •    for p in self.players:
    
  •        p.drawn_cards = []
    

@.***(https://github.com/dfpetrin) Hi Derrik! Asking just in case: is this correct? Did we want to empty the list of drawn cards at every battle turn?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

dfpetrin avatar Jul 24 '23 23:07 dfpetrin