romm icon indicating copy to clipboard operation
romm copied to clipboard

[Feature] Scraping by filename

Open ronzano opened this issue 9 months ago • 9 comments

I added Mame roms to collection, many of them are not recognized by scrapers

Describe the solution you'd like As I can see on Manual math screen, scraping is done by id or game title. It should be done also with filename (screenscraper supports it)

ronzano avatar Mar 31 '25 09:03 ronzano

What did you name the platform folder? MAME ROMs should be stored under (or mapped to) arcade, as that'll match against our internal mame.xml file by filename.

gantoine avatar Mar 31 '25 13:03 gantoine

I mapped it to arcade, the name is correctly resolved but the assets scraping fails (i.e. a random game: woodpeck.zip -> Woodpecker, scraping failed)

Image

ronzano avatar Mar 31 '25 13:03 ronzano

Everything is working as expected, it's just that IGDB and SSFR don't have entries for Woodpecker (but Mobygames does), so you won't get any results for it. We do have that specific game in our MAME list: "woodpeck": {"@name": "woodpeck", "@index": "", "@image": "", "description": "Woodpecker (set 1)", "cloneof": null, "crc": null, "manufacturer": "Amenip (Palcom Queen River)", "year": "1981", "genre": "Platform", "rating": null, "enabled": "Yes"},.

Image

gantoine avatar Mar 31 '25 13:03 gantoine

Screenscaper site does

Image

ronzano avatar Mar 31 '25 13:03 ronzano

Ah I see what's happening here, can you try the "Refresh metadata" option and see if that matches the game? FWIW the filename needs to be woodpeck.zip.

gantoine avatar Mar 31 '25 13:03 gantoine

Same. Looks like search is done by name only. Same is with almost all CPS3 games

ronzano avatar Mar 31 '25 13:03 ronzano

Looks like search is done by name only

@zurdi15 does the search endpoint for SSRF only accept file names?

gantoine avatar Mar 31 '25 13:03 gantoine

SSFR seems to accept a file name (with extension) in a different endpoint we are currently using with the params romtype and romnom.

endpoint: jeuInfos.php

zurdi15 avatar Mar 31 '25 14:03 zurdi15

I managed to get the correct API response to identify that MAME title:

Image

It seems to return the same response with the systemeid of any arcade platform.

We would need to add that endpoint to the SSFR handler

zurdi15 avatar Mar 31 '25 14:03 zurdi15

This has been addressed in v4.0.0 which supports hash-based matching for MAME games.

gantoine avatar Jul 21 '25 03:07 gantoine