libgit2 icon indicating copy to clipboard operation
libgit2 copied to clipboard

Possible strncpy truncation bugs

Open romkatv opened this issue 6 years ago • 0 comments

Got these warnings while compiling on Alpine Linux against musl libc:

/tmp/gitstatus/libgit2/src/refs.c: In function 'git_reference_lookup_resolved':
/tmp/gitstatus/libgit2/src/refs.c:235:4: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
    strncpy(scan_name, ref->target.symbolic, sizeof(scan_name));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 77%] Building C object src/CMakeFiles/git2internal.dir/streams/registry.c.o
/tmp/gitstatus/libgit2/src/refs.c: In function 'git_reference_lookup_resolved.constprop':
/tmp/gitstatus/libgit2/src/refs.c:235:4: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
    strncpy(scan_name, ref->target.symbolic, sizeof(scan_name));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

romkatv avatar Jun 07 '19 17:06 romkatv