Tomasetti Romin

Tests should run with `--gtest_shuffle` to trigger hidden bugs (test dependencies or worse)

2

It seems that `Kokkos` tests aren't being shuffled when they run. I think they should. Attached is an example that illustrates the need for shuffling. If the test `first` runs...

graph(`SYCL`): specialization of `Kokkos::Impl::Graph` is not tested in jenkins CI

5

The specialization of `Kokkos::Impl::Graph` for `Kokkos::SYCL` is never tested for now. This is the piece of code that guard it: https://github.com/kokkos/kokkos/blob/fd8d327ad964bde55b94f9f7c0fb60e7c54c8b03/core/src/Kokkos_Graph.hpp#L187-L189 In the current [scripts/docker/Dockerfile.sycl](https://github.com/kokkos/kokkos/blob/54b739089e5f9b5dab5efaf60f2d40d9530e46f3/scripts/docker/Dockerfile.sycl), the toolchain is just too...

Stokhos(mask logic): `MaskLogic::OP` should take by `const&`

5

## Enhancement @trilinos/stokhos @etphipp When we run tests using ensembles, we want to make floating-point equality checks (or at least comparison within a tolerance). Making such thing *sample-wise* is ensured...

`State::name` returns a string copy

5

I am not sure why the following line returns a copy of the name string: https://github.com/google/benchmark/blob/7f727750846552fb507d778b2b125dd6d32061bf/include/benchmark/benchmark.h#L978 If there is no particular reason, I can make a PR to return by...

Alternative to: - #8113

Goes hand-in-hand with: - https://github.com/kokkos/kokkos-kernels/pull/2654 This PR removes useless special functions and adds a proper copy-convert constructor that allows copy-constructing graphs of different type whose inner members are compatible.

core(graph): add host node

3

### Summary This PR adds *host node* to `Kokkos::Graph`. ### Description Adding a host node creates a new CPU execution node and adds it to graph. When the graph is...

blas(axpby): execution space instance semantics not honored

1

Using `KokkosBlas::axpby`, I could easily get a broken code if both following conditions are met: 1. use rank-0 views for the coefficients 1. pass an execution space instance on which...

TPLs: some code paths do no lead to the expected kernel due to incomplete view [type] inspection (like `cublasDdot`)

1

The following code seems to account for only a subset of the valid conditions: https://github.com/kokkos/kokkos-kernels/blob/9bca19c85b88aeca97209ec7cde858447e16696c/blas/tpls/KokkosBlas1_dot_tpl_spec_decl.hpp#L132-L140 Indeed, both ```c++ Kokkos::View ``` and ```c++ Kokkos::View ``` should map to `cublasDdot` since the...