Tomasetti Romin
Tomasetti Romin
@dalg24 @masterleinad @crtrott What do you think ?
### Motivation - Runtime polymorphism on device > Do you have a good motivation for using `kokkos_malloc` over a `Kokkos::View` allocation? The motivation is mostly related to creating *vtables* on...
@dalg24 @masterleinad If you don't have any further comment, this one is good to go!
> Can you add a test that demonstrates a use case? Would something along these lines be OK for you ? ```c++ //! @test This test ensures that the underlying...
- I wrote a test for `Cuda`, and I basically copy-pasted it for `HIP`. Is the copy-paste the expected testing strategy ? - The test creates a graph through `Kokkos`...
@crtrott So you mean that internally, `ParallelFor` constructor should use `team_size_recommended`, and that the "formula" implemented in `team_size_recommended` is the correct one? And if so, why do we need to...
> Why does it matter here to use `if constexpr`? @masterleinad What do you mean by *here* ?
Good question! I quickly drafted this code to check that with `gcc-12`: ```c++ #include #include #include #include #ifndef CONSTEXPR_OR_NOT #error "CONSTEXPR_OR_NOT must be defined." #endif template class UnorderedMap { public:...
@masterleinad I understand your point of view. It's true that there is no performance gain. However, in light of the (IMO very good) SO answer https://stackoverflow.com/a/54545744, I still think it's...
For the record - this PR extracts changes from #6584.