Tomasetti Romin comments

Results 152 comments of


                                            Tomasetti Romin

Tests should run with `--gtest_shuffle` to trigger hidden bugs (test dependencies or worse)

We decided to create a PR with shuffling environment variables in the Jenkins configuration and some GitHub actions and see what happens. ```patch diff --git a/.jenkins b/.jenkins index c2c6f500f..d50781bc2 100644...

Stokhos(mask logic): `MaskLogic::OP` should take by `const&`

@maartenarnst will also be interested :wink:

Stokhos(mask logic): `MaskLogic::OP` should take by `const&`

Here you go: * #12350

Sacado: `SacadoViewFill` should be used only if needed

> Sounds reasonable. Would you mind creating a PR? Sure! While we are at it, it seems that the specialization of `SacadoViewFill` for device views (Cuda and HIP) is a...

Sacado: `SacadoViewFill` should be used only if needed

@masterleinad I agree that `Kokkos::Impl` shouldn't be used by the "casual" `Kokkos` user. However, especially in this case, specializing the view of `Sacado` objects forces the "specializer" to re-write what...

Sacado: `SacadoViewFill` should be used only if needed

@masterleinad Should we reopen this one?

Sacado: `SacadoViewFill` should be used only if needed

@etphipp ?

Sacado: `SacadoViewFill` should be used only if needed

Given the ongoing refactoring of `Kokkos::View` to leverage `std::mdspan`, I think this issue will need to wait for that to complete. However, it’s definitely worth keeping tabs on — once...

`State::name` returns a string copy

Hum. I'm not sure to understand why C++03 incurred such a restriction... Nevertheless, do you confirm that it should now return by `const auto&` ?

`State::name` returns a string copy

> `auto` didn't exist until C++11, did it? Well, I'm still surprised that it was not written `const std::string&` at the time. So the question is really if there is...