Final separator shifts layout

[romgrk]

[Iron-E]

I was investigating this just earlier, and found our code for inserting the final separator here. Why was the final separator added? Does it prevent a certain category of error when generating the tabline?

Essentially, could we just remove the separator?

[romgrk]

It's there to create a visual separation in cases where the inactive bg color is the same as the fill region bg color. I'd rather keep it if possible. We can probably add a + 1 somewhere in there to avoid shifting the layout in this specific case?

[Iron-E]

For my future reference, the line causing the extra separator to be drawn is here.

[Iron-E]

It's there to create a visual separation in cases where the inactive bg color is the same as the fill region bg color

Now that there is an icons.separator.right option, should we remove this?

• If users want the functionality, they can use icons.inactive.separator.right
• If using icons.separator.right, results like this appear (it makes it seem like there is a third buffer open that got cut off)

[mphe]

• If using icons.separator.right, results like this appear (it makes it seem like there is a third buffer open that got cut off)

In case anyone else stumbles over this problem, I just commented out the following lines in render.lua as a workaround. https://github.com/romgrk/barbar.nvim/blob/f0212c318e0f118ccb0e6166198895f78aa87efd/lua/barbar/ui/render.lua#L610-L617

[Iron-E]

@mphe do you want to submit a PR?

[mphe]

Sure, I'll look into it.