hydra-lightning icon indicating copy to clipboard operation
hydra-lightning copied to clipboard

Published 20 hours ago • verified publisher icon romesco

ModelCheckpointConf wrong default value

Open NikolaiBabkin opened this issue 4 years ago • 2 comments

In hydra_configs/pytorch_lightning/callbacks.py in ModelCheckpointConf there is no default value for feeld dirpath. Should be: dirpath: Any = None according to https://pytorch-lightning.readthedocs.io/en/latest/generated/pytorch_lightning.callbacks.ModelCheckpoint.html

NikolaiBabkin avatar Feb 06 '21 11:02 NikolaiBabkin

Thank you @NikolaiBabkin, I'll look into addressing this upstream in configen, as well!

romesco avatar Feb 12 '21 20:02 romesco

Was this fixed? PR #17 was merged but this issue is still open.

reuben avatar Jun 22 '21 14:06 reuben