hydra-lightning icon indicating copy to clipboard operation
hydra-lightning copied to clipboard

Support for loggers

Open piraka9011 opened this issue 4 years ago • 3 comments

It looks like there's no direct support for Loggers (or other nested structures) used by the Trainer. Is there any plan to suppport that? Is it as simple as running config generation script?

piraka9011 avatar Jan 04 '21 22:01 piraka9011

Hey @piraka9011, that's a great idea!

I've been working on hydra-torch and configen to try to get things finished for supporting the nested structures you're referring to (especially in the context of instantiating datasets/dataloaders/transforms).

I could definitely use some help adding useful configs to this repo in the meantime!

Could you get a PR draft going? With the state configen is in, it should get us pretty close, but there might be a couple tweaks necessary.

I wrote out some steps on how to use configen here: https://github.com/pytorch/hydra-torch/blob/dev/overview/CONTRIBUTING.md#using-configen

romesco avatar Jan 07 '21 15:01 romesco

Also, if needbe, feel free to ping me on the hydra chat: https://hydra-framework.zulipchat.com/#narrow/stream/257092-Hydra-Torch/topic/General @ rosario

romesco avatar Jan 07 '21 15:01 romesco

FYI, I came across this issue when attempting to regenerate the configs: https://github.com/facebookresearch/hydra/issues/1299

piraka9011 avatar Jan 16 '21 16:01 piraka9011