tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 No formatting or lint errors with multiple empty lines

Open talovski opened this issue 2 years ago • 1 comments

Environment information

rome rage   
CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-kitty"
  JS_RUNTIME_VERSION:           "v18.12.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "null"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      <=10.0

What happened?

When I have multiple empty lines, they are not removed and no error is thrown. Example code:

export default function Error({ error }: { error: Error; reset: () => void }) {
  console.error(error);



  console.log('hi');

  return (
    <>

    
      <h1 style={{ color: 'red', backgroundColor: 'blue' }}>Error</h1>
      <NotfoundErrorPage />
    </>
  );
}

Expected result

I would like the formatter to remove them, and also, the linter to throw an error.

Code of Conduct

  • [X] I agree to follow Rome's Code of Conduct

talovski avatar Aug 28 '23 23:08 talovski

Could you:

  • tell us how you format/lint the code (CLI command, LSP, etc.)
  • share repository to reproduce the issue

Also, the rage command says you're running an old server. What version of the extension are you running?

ematipico avatar Aug 29 '23 06:08 ematipico