tools icon indicating copy to clipboard operation
tools copied to clipboard

fix(rome_js_analyze): noRedeclare accepts index signatures

Open unvalley opened this issue 1 year ago • 1 comments

Summary

Closes #4478

Test Plan

cargo test -p rome_js_analyze -- no_redeclare

Changelog

  • [x] The PR requires a changelog line

Documentation

  • [ ] The PR requires documentation
  • [ ] I will create a new PR to update the documentation

unvalley avatar May 20 '23 17:05 unvalley

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
Latest commit 029c4a21063226a895e43b8ba8e74209199bf4b4
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6487086b1954790008f9cbe1
Deploy Preview https://deploy-preview-4519--docs-rometools.netlify.app/playground
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 20 '23 17:05 netlify[bot]

Anything we can do to help get this out of draft?

Vivalldi avatar May 24 '23 03:05 Vivalldi

@Vivalldi

I need to accept the case below while fixing the problem. current implementation is not enough.

type IndexSignatures = {
    [index: number]: string,
    [index: string]: string
}

unvalley avatar May 24 '23 11:05 unvalley