tools icon indicating copy to clipboard operation
tools copied to clipboard

Changed internal rome dependencies to workspace

Open gautamprikshit1 opened this issue 1 year ago • 5 comments

Fixes #4510

gautamprikshit1 avatar May 20 '23 05:05 gautamprikshit1

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
Latest commit ef91020494cfce6751cbedf20163b99d241793fd
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/646859c8ee18aa0008f2c991

netlify[bot] avatar May 20 '23 05:05 netlify[bot]

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

ematipico avatar May 20 '23 11:05 ematipico

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

It's valid to specify default features for internal crates as well:

internal_crate1 = { version = "x.x.x", default-features = false, features = ["..."] }
internal_crate2 = { version = "x.x.x", default-features = true }

Boshen avatar May 20 '23 14:05 Boshen

Didn't work

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

Didn't work same error

gautamprikshit1 avatar May 21 '23 02:05 gautamprikshit1

@gautamprikshit1 I strongly suggest applying the changes gradually, crate by crate. And maybe do a PR only with gradual changes as a starting point.

For example, I just tried to refactor rome_rowan, and it worked. From there, you could make a PR. Let's try this approach :)

ematipico avatar May 21 '23 10:05 ematipico

I will close this PR and start over, Thanks.

gautamprikshit1 avatar May 22 '23 01:05 gautamprikshit1