tools
tools copied to clipboard
Changed internal rome dependencies to workspace
Fixes #4510
Deploy Preview for docs-rometools canceled.
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | ef91020494cfce6751cbedf20163b99d241793fd |
Latest deploy log | https://app.netlify.com/sites/docs-rometools/deploys/646859c8ee18aa0008f2c991 |
I believe some issues are caused by some of our crates that have [features]
. As a starter could you try to refactor only the crates that don't have [features]
in their Cargo.toml
?
I believe some issues are caused by some of our crates that have
[features]
. As a starter could you try to refactor only the crates that don't have[features]
in theirCargo.toml
?
It's valid to specify default features for internal crates as well:
internal_crate1 = { version = "x.x.x", default-features = false, features = ["..."] }
internal_crate2 = { version = "x.x.x", default-features = true }
Didn't work
I believe some issues are caused by some of our crates that have
[features]
. As a starter could you try to refactor only the crates that don't have[features]
in theirCargo.toml
?
Didn't work same error
@gautamprikshit1 I strongly suggest applying the changes gradually, crate by crate. And maybe do a PR only with gradual changes as a starting point.
For example, I just tried to refactor rome_rowan
, and it worked. From there, you could make a PR. Let's try this approach :)
I will close this PR and start over, Thanks.