tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 VS Code extension fails to format on save for TypeScript files

Open tracker1 opened this issue 2 years ago • 3 comments

Environment information

Using VS Code Rome Extension version `v0.24.0`

What happened?

  1. Set "rome.rome" as default formatter for TypeScript and TypeScriptReact in VS Code.
  2. Attempt to format from the code menu.

Results in an error message.

Extension 'Rome' is configured as formatter but it cannot format 'TypeScript' files

Expected result

Expected the file to be (re)formatted according to Rome rul;es.

Code of Conduct

  • [X] I agree to follow Rome's Code of Conduct

tracker1 avatar May 13 '23 18:05 tracker1

This also happens for .tsx files, of type Typescript-JSX

jgentes avatar May 14 '23 22:05 jgentes

Thank you for reporting this. Would you be able to share some log?

They are in the temporary folder of the OS, under the folder rome-logs. Ideally just the logs of when you attempt to format a file .

ematipico avatar May 17 '23 06:05 ematipico

I figured out the issue - apparently this setting became enabled in one of your updates. I don't think I turned it on manually. When I turned it off, everything started working: image

jgentes avatar May 18 '23 15:05 jgentes

I figured out the issue - apparently this setting became enabled in one of your updates. I don't think I turned it on manually. When I turned it off, everything started working:

Same, except I do have a Rome config file in my repo, but maybe this is looking somewhere else.

WesleyYue avatar Jun 24 '23 06:06 WesleyYue

Going to close it, it seems the issue is solved.

ematipico avatar Jun 24 '23 09:06 ematipico