tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 mulitple symlinks pointing to the same file mistaken as "Infinite symlink expansion"

Open toxeus opened this issue 2 years ago • 2 comments

Environment information

CLI:
  Version:                      12.0.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm"
  JS_RUNTIME_VERSION:           "v19.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/1.22.19"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true

Workspace:
  Open Documents:               0

What happened?

mkdir -p a/b/{c,d}
touch a/foo.html
ln -s ../../foo.html a/b/c/foo.html
# without the next line everything works fine
ln -s ../../foo.html a/b/d/foo.html
# rome ci fails
yarn run rome ci ./a

Expected result

It should not fail.

Code of Conduct

  • [X] I agree to follow Rome's Code of Conduct

toxeus avatar Apr 20 '23 14:04 toxeus

related: #4193, #4221

toxeus avatar Apr 20 '23 14:04 toxeus

I also just ran into this issue using Rome 12.1.3. Adding the symlinked files to the list of ignored files in the config also doesn't help anymore once there are multiple links to the same file.

arendjr avatar Jul 24 '23 15:07 arendjr