tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 Big pack of js/ts files that crashes rome

Open qarmin opened this issue 2 years ago • 4 comments

Environment information

Rome 763fd98ad9072a17ca2ef7ed29c6a164eedc8a6b

CLI:
  Version:              0.0.0
  Color support:        true

Platform:
  CPU Architecture:     x86_64
  OS:                   linux

Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 "xterm-256color"
  JS_RUNTIME_VERSION:   unset
  JS_RUNTIME_NAME:      unset
  NODE_PACKAGE_MANAGER: unset

Rome Configuration:
  Status:               unset

Workspace:
  Open Documents:       0

Checking multiple broken javascript/typescript files(similar to https://github.com/charliermarsh/ruff/issues/3721) with rome check file, crashes app in several ways e.g.

Message: byte index 38 is not a char boundary; it is inside '\u{ac257}' (bytes 35..39) of `/ Copyright (c) 212 Ecm򜹵Internat򬉗onal.  "true" All rights 򩸭eserved.`
Source Location: /home/rafal/.cargo/git/checkouts/tools-29b78d514589893f/763fd98/crates/rome_text_size/src/range.rs:48:9
Thread Name: rome::console
Message: assertion failed: start <= end
Source Location: /home/rafal/.cargo/git/checkouts/tools-29b78d514589893f/763fd98/crates/rome_js_semantic/src/semantic_model/model.rs:332:19
Source Location: crates/rome_js_analyze/src/analyzers/complexity/no_multiple_spaces_in_regular_expression_literals.rs:129:41
Thread Name: rome::worker_1
Message: byte index 2 is not a char boundary; it is inside '\u{b8a08}' (bytes 1..5) of `/򸨈       from this software without specific prior written permission.`

List of files(I can easily produce more errors if needed):

Most of files is minimized, so contains max few lines of code

qarmin avatar Mar 26 '23 07:03 qarmin

This should be fixed

ematipico avatar May 08 '23 13:05 ematipico

Not sure if I checked correctly, but from 2103 files I still have panics with 2095 files with b4cfce9b1bd9d81d0b24139745479779fa5adf6b

qarmin avatar May 08 '23 15:05 qarmin

I've started looking into issues.

It's amazing! What do you think if you could integrate your tests with https://github.com/rome/tools/pull/4559 ?

denbezrukov avatar Jun 12 '23 07:06 denbezrukov

New pack of 1936 files that crashes with current latest git version of rome

Message: assertion failed: start <= end
  × processing panicked: begin <= end (1 <= 0) when slicing `/---`
Message: byte index 1 is not a char boundary; it is inside 'Ð' (bytes 0..2) of `Ð    expo`
Message: byte index 1 is out of bounds of ``

Broken.zip

qarmin avatar Aug 28 '23 20:08 qarmin