tools icon indicating copy to clipboard operation
tools copied to clipboard

📎 Support extensible config via "extends" property

Open marcalexiei opened this issue 2 years ago • 1 comments

Description

Support extends key inside configuration file in order to provide the ability to re-use configuration among different repositories.

References:

  • https://github.com/rome/tools/issues/1596#issuecomment-1324825243
  • #4036

marcalexiei avatar Dec 11 '22 17:12 marcalexiei

Bumping this. After the 12.1.0 release, I think we could start implementing it.

We have good diagnostics and a great awareness of the configuration file now. Of course, the extends will be limited only to physical paths:

Yes ✅

{
	"extends": ["./formatter.json"],
}

No ❌

{
	"extends": ["@somelibrary/hey"],
}

cc @rome/core-contributors if you're interested of if there's someone interested

ematipico avatar May 08 '23 13:05 ematipico

No x { "extends": ["@somelibrary/hey"], }

@ematipico does this mean we still can't have a shared package with rome config in monorepos and use it to extend? Especially in larger monorepos I'd love to have shared rome config across all projects. I currently use this approach for tsconfigs for example

Nikola-Milovic avatar Aug 13 '23 09:08 Nikola-Milovic

We're clearly aware of the limitation, but Rome can't resolve dependencies yet. Hopefully soon we will be able to implement it.

ematipico avatar Aug 13 '23 10:08 ematipico