tools icon indicating copy to clipboard operation
tools copied to clipboard

feat(rome_js_analyze): implement `noConstantCondition` rule

Open notmd opened this issue 2 years ago • 1 comments

Summary

Resolve #3961

Test Plan

cargo test -p rome_js_analyze -- no_constant_condition

notmd avatar Dec 07 '22 16:12 notmd

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
Latest commit ea27a3e9bbc6da0134e93ba5578e01d41c1892ac
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6395e608616b1f000874e32d
Deploy Preview https://deploy-preview-4012--docs-rometools.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Dec 07 '22 16:12 netlify[bot]

This PR is stale because it has been open 14 days with no activity.

github-actions[bot] avatar Dec 28 '22 12:12 github-actions[bot]

@notmd Are you still interested in this contribution?

Conaclos avatar Mar 08 '23 16:03 Conaclos

@notmd Are you still interested in this contribution?

hi, @Conaclos I don't have time to continue this PR. Feel free to close or push any additional changes.

notmd avatar Mar 08 '23 18:03 notmd

@notmd Thanks for the quick answer. We will open another Pull Request and will include your contributions as a starting point.

Conaclos avatar Mar 08 '23 18:03 Conaclos

@Conaclos we can cherry-pick the commits, the contributor doesn't need to do anything :)

ematipico avatar Apr 06 '23 14:04 ematipico