tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 false positive for noShoutyConstants on empty strings

Open rosslh opened this issue 3 years ago • 0 comments

Environment information

According https://rome.tools/docs/lint/rules/noShoutyConstants/

Disallow the use of constants which its value is the upper-case version of its name.

Such code snippet should not emit a warning:

const A = ""

https://docs.rome.tools/playground/?code=YwBvAG4AcwB0ACAAQQAgAD0AIAAiACIACgBjAG8AbgBzAHQAIABCACAAPQAgAEEA&typescript=false&jsx=false

If it's alright, I'd like to take this issue on and open a PR.

What happened?

Rome emitted a diagnostic.

Expected result

This code snippet will not raise an error.

Code of Conduct

  • [X] I agree to follow Rome's Code of Conduct

rosslh avatar Nov 26 '22 15:11 rosslh