tools icon indicating copy to clipboard operation
tools copied to clipboard

feat(rome_cli): expose the `--verbose` flag to the CLI

Open leops opened this issue 3 years ago • 3 comments

Summary

Verbose advices on diagnostics are currently unused, as they always get printed when the diagnostic is displayed with PrintDiagnostic. This PR adds a second argument to the diagnostics printer to configure whether verbose advices should be printed, and exposes this setting as the --verbose flag on the relevant CLI commands (check, ci and format).

Test Plan

I've added a few tests to ensure the CLI correctly accepts the new argument. Since we don't have any diagnostic making use of verbose advices yet it doesn't really make a difference in the output though.

leops avatar Nov 21 '22 09:11 leops

Deploy Preview for docs-rometools canceled.

Name Link
Latest commit 12f40b3d2a31634eb3ce9cd0768901cf282720fc
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637e29553759ed00082c9c41

netlify[bot] avatar Nov 21 '22 11:11 netlify[bot]

Comparing feat(rome_cli): expose the --verbose flag to the CLI Snapshot #4 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles
2.5s
from 264ms
0.0
no change
209ms
no change
Chrome Desktop
Chrome Desktop • Cable
2.5s
from 264ms
0.0
no change
336ms
from 22ms
iPhone, 4G LTE
iPhone 12 • 4G LTE
1.09s
from 238ms
0.0
no change
4ms
no change
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G
16.9s
from 1.07s
0.0
no change
209ms
no change

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
JS Parse & Compile
Motorola Moto G Power, 3G connection
2.02s
from 27ms
Total JavaScript Size in Bytes
Chrome Desktop
5.35 MB
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE
5.35 MB
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection
5.35 MB
from 86.8 KB
JS Parse & Compile
iPhone, 4G LTE
472ms
from 10ms

27 other significant changes: JS Parse & Compile on Chrome Desktop, Largest Contentful Paint on Motorola Moto G Power, 3G connection, First Contentful Paint on Motorola Moto G Power, 3G connection, Total Blocking Time on Chrome Desktop, Time to Interactive on Motorola Moto G Power, 3G connection, Total CSS Size in Bytes on Chrome Desktop, Total CSS Size in Bytes on iPhone, 4G LTE, Total CSS Size in Bytes on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, First Contentful Paint on Chrome Desktop, Largest Contentful Paint on Chrome Desktop, Number of Requests on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Speed Index on Motorola Moto G Power, 3G connection, Time to Interactive on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, First Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

calibre-analytics[bot] avatar Nov 21 '22 11:11 calibre-analytics[bot]

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

github-actions[bot] avatar Nov 21 '22 11:11 github-actions[bot]

@leops if you're able to fix the CI and merge it, I might be able to use this new feature for the suppression comments actions.

ematipico avatar Nov 23 '22 13:11 ematipico