tools icon indicating copy to clipboard operation
tools copied to clipboard

🐛 Bug with `noUnreachable` and `finally` block

Open nstepien opened this issue 2 years ago • 2 comments

Environment information

CLI:
  Version:              10.0.1
  Color support:        true

Platform:
  CPU Architecture:     x86_64
  OS:                   windows

Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 unset

Rome Configuration:
  Status:               loaded
  Formatter disabled:   true
  Linter disabled:      false

Workspace:
  Open Documents:       0

Discovering running Rome servers...

Running Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i The client isn't connected to any server but rage discovered this running Rome server.

Server:
  Version:              10.0.1
  Name:                 rome_lsp
  CPU Architecture:     x86_64
  OS:                   windows

Workspace:
  Open Documents:       0

Other Active Server Workspaces:

Workspace:
  Open Documents:       4
  Client Name:          Visual Studio Code
  Client Version:       1.73.1

Rome Server Log:

! Please review the content of the log file before sharing it publicly as it may contain sensitive information:
  * Path names that may reveal your name, a project name, or the name of your employer.
  * Source code

├─11239782ms INFO rome_lsp::server Starting Rome Language Server...

What happened?

  1. Open this playground
  2. Notice that testFAIL has a lint/diagnostic issue, while testOK does not.

Expected result

return null; in testFail is reachable, noUnreachable should not mark this as a lint issue.

Code of Conduct

  • [X] I agree to follow Rome's Code of Conduct

nstepien avatar Nov 10 '22 18:11 nstepien

@nstepien could you please create a new playground and link it? Unfortunately the one provided doesn't work anymore because we changed the URL of the playground.

ematipico avatar Nov 14 '22 11:11 ematipico

@ematipico I've updated the link in the opening comment.

nstepien avatar Nov 14 '22 11:11 nstepien