tools icon indicating copy to clipboard operation
tools copied to clipboard

feat(rome_cli): print number of errors in summary

Open SuperchupuDev opened this issue 3 years ago • 3 comments

Summary

Prints the number of errors emitted on the check summary, or at least tries to. I'm not really experienced in Rust so it's very possible this breaks something / doesn't work as intended, but it does its job, I guess. Feel free to supersede or suggest changes if you have a better approach

Closes #3588

Test Plan

image

Commands ran:

cargo build
cargo run --bin rome check ./my-cool-ts-project

where my-cool-ts-project is a directory with a TypeScript file

SuperchupuDev avatar Nov 10 '22 16:11 SuperchupuDev

Deploy Preview for docs-rometools failed.

Built without sensitive environment variables

Name Link
Latest commit 049cdbd4c70273b8da9781c115a3b5704b91b808
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637264396d81f00008b6c66b

netlify[bot] avatar Nov 10 '22 16:11 netlify[bot]

somehow the snapshot tests are failing after updating them, any idea how i can fix it?

SuperchupuDev avatar Nov 11 '22 20:11 SuperchupuDev

somehow the snapshot tests are failing after updating them, any idea how i can fix it?

We use insta. You have to install it via cargo: cargo install cargo-insta. Then run cargo insta review or cargo insta accept

ematipico avatar Nov 14 '22 15:11 ematipico