📎 Decide on `noUnusedVariables` stability

[MichaReiser]

trafficstars

Description

Decide whether noUnusedVariables should be shipped as stable or nursery rule.

[xunilrj]

I vote for yes. Don't know any major issue with it.

[ematipico]

At the moment the rule is inside a stable group, not recommended. I am OK to keep it the in stable group and recommended it.

[xunilrj]

I would not recommend it for the moment, and for one simple reason: on the eslint repo, for example, it flags dozens of unused variables. A lot of the cases are silly things like copy and paste, function contracts etc... They are really not bugs.

We would be forcing a lot of code changes with no obvious gains for the users.
As time passes, we will give time for people to fix this issues and this rule will generate less churn for nothing.

[ematipico]

I would not recommend it for the moment, and for one simple reason: on the eslint repo, for example, it flags dozens of unused variables. A lot of the cases are silly things like copy and paste, function contracts etc... They are really not bugs.

We would be forcing a lot of code changes with no obvious gains for the users. As time passes, we will give time for people to fix this issues and this rule will generate less churn for nothing.

Good point!

[github-actions[bot]]

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella